Skip to content

CNTRLPLANE-2586: postpone the removal of the DeploymentConfig API #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
atiratree wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CNTRLPLANE-2586: postpone the removal of the DeploymentConfig API #2646

atiratree wants to merge 2 commits into from
+12 −12

Conversation

@atiratree
Copy link
Member

@atiratree atiratree commented Jan 13, 2026

No description provided.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2026

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 13, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2026 •
edited by openshift-ci bot
Loading

@atiratree: This pull request references WRKLDS-1766 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2026

Hello @atiratree! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@coderabbitai
Copy link

coderabbitai bot commented Jan 13, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

This pull request updates prerelease lifecycle metadata for multiple types in apps/v1. The APILifecycleRemoved value was changed from (4, 10000) to (6, 0) for DeploymentConfig, DeploymentConfigList, DeploymentConfigRollback, DeploymentRequest, DeploymentLog, and DeploymentLogOptions. Changes appear in apps/v1/types.go and apps/v1/zz_prerelease_lifecycle_generated.go. No type signatures or runtime control flow were modified.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to evaluate whether the description relates to the changeset. Add a description explaining the rationale for postponing the DeploymentConfig API removal and the significance of updating the lifecycle version.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: postponing the removal of the DeploymentConfig API, which is directly supported by the code changes updating lifecycle versions from 4.10000 to 6.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 13, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atiratree
Copy link
Member Author

atiratree commented Jan 13, 2026

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2026
everettraven
everettraven reviewed Jan 14, 2026
View reviewed changes
apps/v1/types.go Outdated
// +k8s:prerelease-lifecycle-gen:introduced=3.0
// +k8s:prerelease-lifecycle-gen:deprecated=4.14
// +k8s:prerelease-lifecycle-gen:removed=4.10000
// +k8s:prerelease-lifecycle-gen:removed=5.10000
Copy link
Contributor

@everettraven everettraven Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC the outcome from the arch call was to use 6.0?

@atiratree atiratree changed the title WRKLDS-1766: postpone the removal of the DeploymentConfig API CNTRLPLANE-2586: postpone the removal of the DeploymentConfig API Jan 21, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 21, 2026 •
edited by openshift-ci bot
Loading

@atiratree: This pull request references CNTRLPLANE-2586 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@atiratree
Copy link
Member Author

atiratree commented Jan 21, 2026

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 21, 2026 •
edited by openshift-ci bot
Loading

@atiratree: This pull request references CNTRLPLANE-2586 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@atiratree atiratree force-pushed the deployment-config-removal branch from 6a30f3a to 6b14002 Compare February 9, 2026 20:19
@atiratree atiratree force-pushed the deployment-config-removal branch from 6b14002 to 22c911d Compare February 9, 2026 20:49
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2026

@atiratree: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-images 22c911d link true /test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@everettraven everettraven everettraven left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@atiratree @openshift-ci-robot @everettraven